What coding habits grind your gears?

Posting as :
works at
You are currently posting as works at

Poorly named variables. Stay away from single letter names unless it's *very* clear from the context. (I know what everything in "F=m*a" is without you spelling it out.) Not too long either though. I don't want to scroll my editor right just because you've got names that are sentences long.

likesmart

Jacked up indentation. I see you out there lunatic with no indentation.

Hard-coded magic numbers.

No comments.

One letter variables. I'm less against this if the variables tie to a math formula. Then I'm ok with it but it the formula in the comments in that case.

Referring to dataframe columns by number. Because we'll never change the file format.

Vectorize your code people (R).

Could I get a sentence in what your function does? That would be helpful. It would also be cool if we added some tests.

I could go on.

like

data <- fread(“data.csv”)
df1 <- fread(“df.csv”)

Yes, in professional work, we will use one data file, work on one project, and everybody will understand that one file will rule them all

like

In general I can’t stand lack of comments if you expect someone to read it

like

One more: when people leave a comment like "calculate the average" to explain a function named "calcAverage()".

like

Inefficient programming like using loops where not necessary and increasing the time complexity.

like

No loggers

@BA1, I find it useful to leave comments everywhere. Sometimes the younger India teammates don’t jump to the same immediate conclusions...though in your example I sure as shit hope they do.

Related Posts

Have any of the partners you work with kind of just...disappeared? I work with a few in my office (mostly 1, let’s call them MP) and do some work for partners in another office (let’s call them OPs). My deals with MP have gone on hold so I’ve been taking more work from OPs. When something w MP does come up, I’m always rushed off the phone and can only get a hold of them once every 2-3 weeks to catch up in general. I get that it’s hard to wfh w/ young kids and a fellow Biglaw spouse...(cont’d)

like

Hi folks, I'm really confused b/w Dallas and Austin terms of deciding where to buy my single-family home.
For people living in Austin, what are some top pros and cons of living in Austin compared to Dallas?
Appreciate your inputs...

like

Hiring account roles from AE to Director. HCP and DTC offerings (including tv). DM me for more info.

like

I’m looking to create a course on how to market yourself as an entertainer. I have experience booking gigs as a poet, but I’m interested in seeing how I can partner with other successful artists

like

Can someone legitimately explain to why bankers take so long to come up with LBO models on the financing side, and refuse to allow us to review them in detail? We provide preliminary feasibility analysis on loans on so many deals and the difference of what the bank comes up with is always minimal, but always takes a month? Can anyone walk me through what happens on the other side? It tends to be very frustrating.

like

What’s the best benefit at your firm?

like

PHR or SHRM-CP?

like

Just finished reading One Flew Over the Cuckoo’s Nest. It was triggering but in a way that helped me confront some issues that I couldn’t even tell my own therapist about. I highly recommend it.

likeuplifting

What do you think it would take for stocks to reflect the economic reality? Pic related.

Post Photo
likesmartfunny

I'm a former strategy consultant (left as an M), few years in industry now, with an M7 MBA. Currently live in a HCOL US city, and want to move back to London in the longer-term, but concerned about pay. Outside of consulting and finance, is it remotely feasible to get industry roles with £350k base? I'm on about $400k TC right now.

like

Hey Fishes ,
I want to know does TCS takes any self declaration before releasing the offer letter?
This is for C2 level.
I have not received my offer letter yet and they said give us self declaration and will release offer letter.
I have not yet received their declaration form.
What exactly is this exactly?
Thanks in advance for help!!

like

Does anyone have any recommendations on resume/LinkedIn writers ?

like

I sometimes eat edibles/weed gummies for anxiety - should I stop doing that during my stim cycle? Anyone know if this is potentially harmful? I don’t plan on drinking alcohol during it.

I’m not old BUT when I was younger I thought it was important to have all the alphabets after my name (I.e. Phr, SHRM and all the others). I learning that the younger crowd coming into the market thrives off these identifiers yet they know very little about the real world aspects of the job. I watch leadership roll their eyes at the email footers. I feel like keeping those attached to my name hurts my credibility so I removed them…. I’m I thinking wrong?

like

Actively Looking for the Job as a SAP FICO Consultant.
Serving Notice Period (LED - 11th Feb 2022)
YOE - 2.5 Years
Please let me know if you have any Job vacancy in your organization.
Thank you and have a good day.

like

What’s everyone doing this weekend

like

How to say No to a demanding customer during Implementation phase?

like

How have people in this community found the shift to leadership. In my personal experience I found individual contribution tough but then did much much better as a people / team leader. Is this just me or reflective of the broader group here?

like

Hello. Does anyone know someone who is interested to hire a foreign trained dentist as dental assistant? The thing is that I don't have work visa as well...

like

Additional Posts in Data & Analytics Consultants

When industries refer to business intelligence engineers, are they looking at a senior level or entry level? Some of these job descriptions seem rather outlandish in terms of years of experience required like 5+

like

what do you all think about online data MS programs as opposed to in person?

like

Are there non intel federal agencies that are directly hiring data scientists, as opposed to using contractors? There are a lot of "analyst" positions but the descriptions are vague.

like

Firm is reimbursing 2k for certs - any recommendations from the list? Currently doing RPA/Alteryx/Power BI and want to pivot towards DS/AI/ML with a splash of data management and RPA. Have prior coding exp in R/SQL/Python. TIA

Post Photo
like

How are treasury analyst positions? Anyone in that area?

like

I feel like rushing my career in Data science. The market is moving very quickly. I have this urge to jump to new adventures seeking more interesting challenges and trying to be always up to date.

Currently have 5 YOE in DS consulting

Looking to create a personal portfolio website for my data visualization and dashboard work with the firm. Is it okay to use screenshots (scrubbed with fake data obviously) from my client dashboards on my portfolio? I would blur out Deloitte logo and such , but it would be great to showcase my work dashboards on personal portfolio just because I’ve done so much solid stuff there. Would this be okay from a legal standpoint or risky?

like

Have any DS/ML professionals made the switch to Chief of Staff roles? Was it a good decision? Are those roles interesting?

like

Does anyone here work in the Data Science track for McKinsey marketing and sales group? Entered the interview process (post quanthub exam) and would looking for insight on what to expect from the live rounds.

like

Where are the best places to work for accelerating a career in data science? Any unexpected companies?

like

What are the exit ops for someone <2 years into etl dev/data engineering/analytics? Not sure this is for me and I’m scared I’ll be stuck as a dev forever

like

I’ve been interested in entertainment / streaming analytics for some time (e.g. amazon, Netflix, Hulu etc.). Anyone know any useful skills, classes or certifications that might be good to have in this arena?

like

Trying to prep for Tableau certification. Is there a particular site that you have used you would recommend?
Tableau noob trying to fig out the best way to go about this

like

If I had a ML app backend coded in python and I want to slap on a front-end that's primarily a mobile app or in-web desktop app, how do I go about doing that? I'm trying to turn it into a SaaS product.

like

Once i have the market basket association rules..
What TF do i do with them?

like

Best books, courses, or other resources on NLP?

like

Best free visualization tools?

like

Who’s hiring right now? And pays well? I got a couple years experience at big 4 and looking to make a move to get into the 6 figure salary

like

Anybody looking for data strategy or technical PM for analytics projects?

likehelpful

New to Fishbowl?

Download the Fishbowl app to
unlock all discussions on Fishbowl.
That was just a preview…
Sign Up to see all discussions
  • Discover what it’s like to work at companies from real professionals
  • Get candid advice from people in your field in a safe space
  • Chat and network with other professionals in your field
Sign up in seconds to unlock all discussions on Fishbowl.

Already a user?
Login here

Share

Embed this post

Copy and paste embed code on your site

Preview

Download the
Fishbowl app

See what’s happening in your industry
from the palm of your hand.

A phone with Fishbowl app

Send download link to your phone

OR

Scan your QR code to download
Fishbowl app on your mobile

By continuing you agree to Terms of Use and Privacy Policy.

Messaging rates may apply

Download app

Sign up for free to view this conversation on Fishbowl

By continuing you agree to Terms of Use and Privacy Policy

Already have an account? Log in

Sign up for free to continue using Fishbowl

By continuing you agree to Terms of Use(New) and Privacy Policy(New)
Messaging rates may apply

Already have an account? Log in

For account settings, visit Fishbowl on Desktop Browser or

General

Legal