I know our codebase better than most since I built the foundation, but my feedback is being ignored during reviews. My coworkers push messy code, our lead merges it to meet deadlines, and then I’m the one dealing with the fallout when it inevitably breaks. How do I get my team to care about the "why" behind my feedback instead of just ignoring me and rushing to finish? The cycle of constant bugs and fixes is slowing us all down.

like
Posting as :
works at
You are currently posting as works at

A 'You break it, you fix it' policy would take care of it pretty quick

like

lol this is right

like

Formalize feedback into a process. Either a direct one (lint rules/test rules/etc) or process rules. (Checklist for signoff)

If it leads to a problem/incident justify the change in process with those docs.

If it's just nits/nuance that doesn't lead to large problems at best you can document updates in a backlog or something.

What about when process is ignored?

like

I’d bring it up in a retro or bring it up to your project manager

Depending on the issue it's often better to enforce quality by design and automated checks. Your comments maybe great and even if they took action on the feed back you can't possibly catch every issues or review every PR.

Can the design/architecture be improved so that the anti-pattern is less likely? Can style checks or linters be used? to enforce project standards?

You can implement plugins that can help. For instance if it’s Java apps there’s some maven plugins that you can set a required unit test line coverage. If they don’t meet the coverage then the build fails

Is SAST in placeAnd part of definition of done to have certain number or grading of code smells?

I've been there, and the only way I found was to leave.

Related Posts

Can anyone help me i am have a different situation here i left the job based on a phone conversation with tech Mahindra since they are asking for an immediate joiner. Now after submission of all documents they are not giving proper response .. every time they call me and ask me some documents is missing and some time BG status not received.. i don't what to do ..no job now and even no offer from them.

Resigned already 30 days back

Got 75% from accenture

Feeling like I should revoke resignation.

I am actually loving the people I am working with.

Not sure what is waiting for me in new company.

Will I regret leaving deloitte for accenture?

like

Hi Fishes,
Joined @ Nov, 2021 in Operations at CL 12.2
My total experience is 6yrs (8mon in Accenture)
My current CTC is very low, 4.77lpa. Got 10% for September cycle.
1) when is the annual appraisal cycle, when we will get the hike letter? Approx hike %
2) will we get additional hike for sub-level change from 12.2 -> 12.1?

like

What's this deal with 11 likes?
I see a lot of y'all posting it.

like

Hey everyone! We just launched an IG called @greeenergrass dedicated to highlighting individuals who are either trying to break into creative, entering the work force, or want to move on to greener pastures. Make finding your best work easy!

You can DM or email if interested in being featured OR if you want to take it one step further, we’ll use our professional media planning expertise to run ads for your work, whatever your budget, with absolutely no extra costs.

Be sure to check it out!

like

Has anyone been offered a status buy-up for 2021. ~$1700 short of United 1k this year and think my travel will increase a good bit starting next year. Think it could make sense, especially given the 2021 thresholds

like

If you were thinking Consulting Cases were bad here is a hedge fund interview 😂

Post Photo
funnylike

Anybody got any fire penny stock plays? IDEX is mine, but I’m looking for more!

like

Is Early release available in Cognizant ? I need join the new company in 30 days

like

Does anyone have a LV watch roll? Worth it? Open to their similarly priced options (~$1k).

Post Photo
likefunny

Favorite group fitness in philly?

Everyone: Excel is a smart app
Excel:

Post Photo
likefunny
like

Anyone familiar with SmartHop?

like

Guys...how to follow up with HR without sounding desperate?

like

Heloo fishes, Which SAP module have better future opportunity- SAP FICA or SAP BRIM?

like

To the author the the “Lately I’ve been getting the vibe that I am [being Frozen Out (BigLaw term of art for your concerns or situation)]. My TOME on how to handle the situation through every route if and until you leave BigLaw appears to have suddenly NOW posted. 🤷🏻‍♀️🤦🏻‍♀️. My keyboard is sticking on the site so there are surely typos (I long ago turned off Auto-Corrupt). My sympathy, best wishes, and offer of trustworthy support(BEEN THERE, SEEN IT, put in my decade in BigLaw) still stands.

like

Can anyone speak to the analytics team within HIA at PwC? Good capability, culture, and people overall? Considering a move.

like

What designation i can expect iat Capgemini of joining as a Lateral?

I have total 11.5 YoE

like

Is the EPGP programme from IIM Kozhikode worth it?

like

Additional Posts in Software Engineering

Where/ how can I learn Azure?

like

Given the continuing chip shortage situation- what changes are you making to your embedded code bases to handle hardware changes?

like

Our team is searching for a seasoned oracle developer specializing in retail/ecommerce, along with cloud exp. Fully remote. If your interested DM me.

like

Best way to get ahead in software engineering? Learning additional skills? Really curious if anyone here made a big income jump through making any particular kind of change

like

My husband is going through the interview process at Vanguard for an entry level software engineering role. He just graduated bootcamp but had been self studying for years as well. He's definitely junior level. What kinds of questions should he expect in his technical interview?

like

Okay, I feel like if a QE in India needs to email me, an SE, to just press the 'resolve' button on a user story that was created after a bug report was issued and fixed, then maybe... Just MAYBE... There might be a bureaucracy problem. 😒

likefunny

Hello everyone,

I love in Europe and was wondering how difficult or easy getting remote front end position in a US company would be and if the salary would be the same as a US citizen who lives in the US?

like

Is 120k+super a good salary for software tester (manual) with 7 years of experience in Melbourne?

like

What drives people to answer stackoverflow questions? I love them for doing so, but when will I feel the urge to contribute?

like

Serious question from a happy software engineer, what do you all love about your work/actually enjoy doing during working hours?

I'll start; I'm privileged enough to have been given the opportunity to work and learn deeply on Linux and Kubernetes, and I get to tinker and play with them all day. Problem solving with them is a "fun" part of my job.

Of course most things aren't roses and sunshine, but I'd love to hear the positive parts of what you are doing, or what you like to do at work.

like

Would like some tips on how to prepare for Senior Fullstack Developer tech interviews. What kind of questions should I expect? Any other tips on how to prepare? TIA

like

Hello Pals - I have 8+ years of exp as business analyst, and consultant. No coding experience, but good in data & reporting. Planning to take a course from Learnbay after reading a lot of reviews in the internet. Its for Data Science Master program - can anyone suggest if they are good and help me make the transition I'm looking for (Feel free to share your choices if any)

like

Trying to learn how to automate work using python. The specific task I wanna do is using information from a different webstie to create zendesk tickets. Any good resources I can use?
Thank you

We're seeking a Manhattan Active SWE. Whose experienced with design and dev SaaS solution. Someone hands on exp with Java 1.8, Spring Boot, Kafka, and Aws. Along with expertise in microservices architecture. Send me a DM if you feel you fit the mold.

like

I am trying to figure out how to switch to SWE. I have a masters in civil engineering and have a good background in higher level math. It looks like the better coding boot camps are quite expensive. The alternative is another masters in CS which is the same cost as many boot camps. Any recommendations on picking between a coding boot camp and getting another masters degree in CS? I’m looking to get into the best position possible after getting an education in CS (get a job quick and good pay).

likeuplifting

Has anyone else worked two programming roles at one time?
I currently work as a Contracted Software Engineer and I’m set to finish my contracted time at the end of October. To stay ahead of game I started to move forward in the interview process with another opportunity as an Application Software Programmer and just received notification that I got the position. I definitely could use the extra paycheck to help out with my financial obligations. Just wanted to see if anyone has done this before.

like

I'm working in the US under H1B, I got a chance to face an interview for another company. My current company started the PERM application also and results will be out within the next 3 months. Is it okay to transfer my H1B to a new company? Can my H1B transfer be denied? How long will my green card application delay if I move to a new company and start to apply for a green card from scratch?

like

Hello!
I’m a student majoring in Software Engineering. I’m starting my third year in a few months and have an internship where I’m learning more about working with an actual team on real-world projects. However, I feel like I need to do more to stand out and have a stronger software background. Anyone have any tips or suggestions for what I should do on my own time to strengthen my skills?

like

My coworker tried to tell me that react is an API….

funny

New to Fishbowl?

Download the Fishbowl app to
unlock all discussions on Fishbowl.
That was just a preview…
Sign Up to see all discussions
  • Discover what it’s like to work at companies from real professionals
  • Get candid advice from people in your field in a safe space
  • Chat and network with other professionals in your field
Sign up in seconds to unlock all discussions on Fishbowl.

Already a user?
Login here

Share

Embed this post

Copy and paste embed code on your site

Preview

Download the
Fishbowl app

See what’s happening in your industry
from the palm of your hand.

A phone with Fishbowl app

Scan your QR code to download
Fishbowl app on your mobile

Download app

Sign up for free to view this conversation on Fishbowl

By continuing you agree to Terms of Use and Privacy Policy

Already have an account? Log in

Sign up for free to continue using Fishbowl

By continuing you agree to Terms of Use(New) and Privacy Policy(New)
Messaging rates may apply

Already have an account? Log in

For account settings, visit Fishbowl on Desktop Browser or

General

Legal