What’s your take on oversized Pull Requests? Knowing that it’s the norm of AI assisted development, automation hasn’t still caught up with humans reviewing the changes.. I would and still reject overly large PRs for reasons outside of testing and fixtures.

like
Posting as :
works at
You are currently posting as works at

It's a lot to review manually and will eat more time for tech leads and senior devs to be sure the changes are intended and fully tested properly.

I push my team to include screenshots and test results to ensure stability

like

Or of curiosity, is there a reason you haven't tied in test results into the PR automatically?

Typically anything that can be run in CI i auto connect it to bot comment on the PR.

I imagine even for front end e2e tests you could do something like that with playwright or similar?

like

It's got nothing to do with AI assisted work. What drives pull request size is:

1. Lack of proper scoping.
2. Brittle code structures.
3. High risk tolerance.

And that usually results in:
1. High effort for PRs.
2. High instability of your deployments.
3. Lower overall velocity & frequency of delivery.

I've seen this happen before AI coding assistants and with it as well. Entirely comes down to good developer discipline.

like

Related Posts

Does EY’s vision plan not cover eye exams?

like

Abu and Rajah.

Post Photo
likefunnyupliftingsmart

All I want to do is curl up in bed with hot tea and a good book. Recommendations for if I ever achieve said dream?

like

29 M - Any one in Montreal for a relationship?

like

Pennsylvania, you're killing me.

like

Hi Fishes,
I am going to join ZS in 2 weeks. It was mentioned in the OL that I will be provided a accomodation for first 2 weeks .
It would be great if you guys please throw some idea on thi..
As, how is the quality of the accomodation?
Is food also available there??
Can I take my parents??

like

To all AEs in the fishbowl, if I am a consultant in sfdc space what is some advice on how I can get time w an AE or get on some preferred list of consultants that an AE might use to help their clients? New in consulting space at the moment but years in SFDC space

Hi fellow fishes, just received an offer for EY cap. Markers as an M, and wanted to get your view on how life at EY is like e.g. work life balance etc. Also wondering why EY has such a terrible rating (just 1.6) on Glassdoor. It’s kinda scary it’s so low

like

For product marketing manager what does rhe day to day look like? Any youtube videos yall can share?

like

𝐂𝐫𝐨𝐬𝐬-𝐄𝐧𝐭𝐢𝐭𝐲 𝐑𝐮𝐥𝐞𝐬

Cross-entity rules can set values for fields in a different entity. Currently it is supported only for specific employment-related entities.

#SAP #SuccessFactors #HXM #HR #EmployeeCentral

Post Photo
like

How many fishes here who have got more than 500% hike while switching?

like

Anyone who moved from offshore audit practices to industry for better WLB?

like

Are any American consultants working in the middle east? Currently, trying to make the transition myself! Grew up in America, but my whole families from the middle east, so I want to do it for a couple of years.

How would I go about this process? Should I join a firm first, then make the transition?

like

Anyone with experience with the snoo and any feedback on it? Have a friend that offered to let me borrow hers, so no cost considerations to think about, but have read that it could cause a flat head/other issues and just curious as to what experiences people have actually had with it. Thanks!

like

What is everyone’s thoughts on partners voluntarily leaving the firm?

like

Who has best AAS service line in Seattle? Looking to transfer. 2 YOE in KPMG audit in TX and a few months in industry. TIA

like

What are the average age brackets at Big 4 to be a Con, Senior Con, Manager, Senior Manager, Director, Partner? Keen for people’s perspectives.

like

Looking for roles in PE Business Development so let me know if you hear about a fund hiring. Or if you know someone that will speak with me or a good recruiter in the space, any leads would be greatly appreciated!

like

When did you tell work about your pregnancy?

Today I was thinking about different sales experiences I’ve had–both as the buyer & the salesman. What was the best and/or worst sales experience you’ve ever had as a customer?

helpful

Additional Posts in Software Engineering

Is it common to negotiate software engineer salary at smaller companies? I know it’s common at FAANG, but what about for companies with around 200 engineers? I have a counter offer from my current company and on-site interviews scheduled for end of July with google and Amazon, but I’d prefer to go with the smaller local company if I can negotiate the salary (from offer letter) up another 5% or so.

like

Would like some tips on how to prepare for Senior Fullstack Developer tech interviews. What kind of questions should I expect? Any other tips on how to prepare? TIA

like
like

What should I reasonably expect from a junior?

I manage a junior developer that's been with the company for about 18 months. I end up providing them of TON of support. I need to give them extremely detailed instructions or they fail. For bugs, I need to point them to a specific function that's causing the bug. For new features, I'm basically writing their method signatures and defining their test cases.

I've tried asking them to do more on their own, but when I do, they fail spectacularly.

likehelpful

I am a contract employee that was just brought on a month ago. I have done well with onboarding and learning their tech. I have now been asked to design an architecture for an upcoming project, and document it all. Nothing at this company has been well documented before. I have a feeling they just planning to use my previous experience and then let me go since my pay is high. Is there a way I can safeguard against this?

Does anyone have any advice for a junior C++ engineer. Or do companies generally don't hire a specific language. You just have to take on whatever code work is available. Are you specifically hired for a particular tech in your company? Or most of the time you just end up not doing it at all?

like

Anyone working with Goldman Sachs in the engineering field up for a little chat ? Kindly do me Goldman Sachs

like

We're seeking a Manhattan Active SWE. Whose experienced with design and dev SaaS solution. Someone hands on exp with Java 1.8, Spring Boot, Kafka, and Aws. Along with expertise in microservices architecture. Send me a DM if you feel you fit the mold.

like

I just got a job offer for an Entry Level Software Engineer at Boeing in Saint Louis. The salary is $82,000 with an $8,000 sign on bonus. I was hoping for an offer closer to 90k base and I don’t care too much for a sign on bonus. However, this is a lot more than what I’m making now, and would be my first SWE job. Should I counter? If so, how would I go about doing that? Thanks!

like

I'm working in the US under H1B, I got a chance to face an interview for another company. My current company started the PERM application also and results will be out within the next 3 months. Is it okay to transfer my H1B to a new company? Can my H1B transfer be denied? How long will my green card application delay if I move to a new company and start to apply for a green card from scratch?

like

Hi,
I am looking to renew my contract with a telecom giant in Toronto, Canada . I am a back end java developer with experience in micro services. Overall experience of 6 years . What is the market per hour rate for the above skills ? Don’t want to undersell myself . Need your insights !
Thank you !

like

Any top tips for a systems design interview? Thanks in advance

helpful

What do you think about switching tech stacks vs becoming an expert in one stack? I am a backend Java engineer, and have solely used Java since I've started my software engineering career about 2 years ago. I don't know whether I should explore other tech stacks while I'm young, or instead focus on becoming a Java expert, given that I enjoy working in Java.

like

Please help. I’ve moved up the ranks pretty quickly at the company I work for to become a Principal SE. My manager thinks the best next step for me is to move into management and leadership and has started pushing me to apply for an engineering manager role. They say that I will be a good fit because of my strong technical background paired with the leadership and people skills I display currently.

I’m torn because I do love being an IC but I’m interested in leadership also. What do I do?

likefunny

If someone wants to change from help desk work to programming but can't afford pricey schools what language would most beneficial to learn? And do you have recommendations for where/how to learn?

like
like

Engineer 🐠

Has anyone personally learned how to build an AI based tool/ app - is it hard?

How does one source this type of talent?

likefunny

I can't find a really interesting bowl here.

Does anyone know or be interested in an open-source bowl, for example?

Please suggest me good bowls 🙏

like

Okay, I feel like if a QE in India needs to email me, an SE, to just press the 'resolve' button on a user story that was created after a bug report was issued and fixed, then maybe... Just MAYBE... There might be a bureaucracy problem. 😒

likefunny

New to Fishbowl?

Download the Fishbowl app to
unlock all discussions on Fishbowl.
That was just a preview…
Sign Up to see all discussions
  • Discover what it’s like to work at companies from real professionals
  • Get candid advice from people in your field in a safe space
  • Chat and network with other professionals in your field
Sign up in seconds to unlock all discussions on Fishbowl.

Already a user?
Login here

Share

Embed this post

Copy and paste embed code on your site

Preview

Download the
Fishbowl app

See what’s happening in your industry
from the palm of your hand.

A phone with Fishbowl app

Scan your QR code to download
Fishbowl app on your mobile

Download app

Sign up for free to view this conversation on Fishbowl

By continuing you agree to Terms of Use and Privacy Policy

Already have an account? Log in

Sign up for free to continue using Fishbowl

By continuing you agree to Terms of Use(New) and Privacy Policy(New)
Messaging rates may apply

Already have an account? Log in

For account settings, visit Fishbowl on Desktop Browser or

General

Legal